Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate XTOS on imx8/imx8x platforms #8856

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

LaurentiuM1234
Copy link
Contributor

@LaurentiuM1234 LaurentiuM1234 commented Feb 12, 2024

To prepare for XTOS deprecation and switch to Zephyr native drivers on i.MX8QM/i.MX8QXP, remove the ability to build SOF with XTOS on said platforms. Also, remove all XTOS builds/tests for these platforms from CI.

@LaurentiuM1234 LaurentiuM1234 changed the title scripts: xtensa-build-all: remove imx8/imx8x [TEST] scripts: xtensa-build-all: remove imx8/imx8x Feb 12, 2024
@LaurentiuM1234 LaurentiuM1234 changed the title [TEST] scripts: xtensa-build-all: remove imx8/imx8x [TEST] nxp: deprecate XTOS on QM/QXP Feb 13, 2024
@LaurentiuM1234 LaurentiuM1234 force-pushed the xtos_depr_qm_qxp branch 2 times, most recently from e9622e1 to 4e7b384 Compare February 13, 2024 11:26
@LaurentiuM1234 LaurentiuM1234 changed the title [TEST] nxp: deprecate XTOS on QM/QXP nxp: deprecate XTOS on QM/QXP Feb 13, 2024
@LaurentiuM1234 LaurentiuM1234 marked this pull request as ready for review February 13, 2024 11:36
@dbaluta
Copy link
Collaborator

dbaluta commented Feb 13, 2024

Thanks @LaurentiuM1234 I'm discussing now with our Yocto team in order to define the strategy of removing XTOS support. Will merge this once we have an agreement.

Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some public, very short document comparing "QM" versus "QXP" and a small table showing which "imx8?" belongs to what? It's pretty cryptic otherwise.

Can this wait until Zephyr updates are unblocked? I mean:

@LaurentiuM1234
Copy link
Contributor Author

Is there some public, very short document comparing "QM" versus "QXP" and a small table showing which "imx8?" belongs to what? It's pretty cryptic otherwise.

Sorry for the confusion. Not sure we have that. Maybe @dbaluta can help here. For reference:

  1. imx8 - QM
  2. imx8x - QXP

The "imx8" and "imx8x" naming stems from the name of the family.

Can this wait until Zephyr updates are unblocked? I mean:

The transition is blocked by the same issue anyways so this can wait as well

@iuliana-prodan
Copy link
Contributor

Is there some public, very short document comparing "QM" versus "QXP" and a small table showing which "imx8?" belongs to what? It's pretty cryptic otherwise.

https://www.nxp.com/products/processors-and-microcontrollers/arm-processors/i-mx-applications-processors/i-mx-8-applications-processors:IMX8-SERIES
From this link you can go for i.MX 8 or i.MX 8X or i.MX 8ULP or
i.MX 8M Plus - in each of this links look for "Part numbers include: "

@dbaluta
Copy link
Collaborator

dbaluta commented Feb 14, 2024

Is there some public, very short document comparing "QM" versus "QXP" and a small table showing which "imx8?" belongs to what? It's pretty cryptic otherwise.

Family Instance name Application processor cores DSP
i.MX8 i.MX8QM 2 x Cortex A72 + 4 x Cortex A53 HIFI4@666Mhz
i.MX8X i.MX8QXP 4 x Cortex A35 HIFI4@640MHhz
i.MX8M i.MX8MPlus 4 x Cortex A53 HIFI4@800MHz
i.MXULP i.MX8ULP 2 X Cortex A35 HIFI4@528Mhz

image

@marc-hb
Copy link
Collaborator

marc-hb commented Feb 15, 2024

Thanks for the table, it is useful. I initially wondered whether it would be useful to add such a table as a comment somewhere here or in sof-docs but I suspect there's a much simpler solution...

Would it be possible to very simply avoid "QM" and "QX" in commit messages and sources completely and just stick to "imx8" and "imx8m" as it has been done until now? As far as SOF is concerned it looks like a 1:1 mapping so far so it does not look like information would be lost if dropping "QM" and "QX" completely?

CI compiles multiple configurations in many different ways so the time wasted to find this sort of mapping can add up quickly; it's not negligible. Also, fixing issues in other vendors' configurations is always quite stressful so every little helps.

@LaurentiuM1234 LaurentiuM1234 changed the title nxp: deprecate XTOS on QM/QXP Deprecate XTOS on all NXP platforms Feb 15, 2024
@LaurentiuM1234 LaurentiuM1234 changed the title Deprecate XTOS on all NXP platforms Deprecate XTOS on all imx8/imx8x platforms Feb 15, 2024
@LaurentiuM1234 LaurentiuM1234 changed the title Deprecate XTOS on all imx8/imx8x platforms Deprecate XTOS on imx8/imx8x platforms Feb 15, 2024
XTOS will be deprecated on imx8/imx8x and these platforms
will be moved to native Zephyr so remove them from the
QEMU boot test which uses SOF with XTOS.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
XTOS is going to be deprecated on imx8/imx8x so replace
imx8 with imx8m.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
XTOS is going to be deprecated on all NXP's platforms so
replace imx8 with AMD's rmb so that the CI test can be kept.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
To prepare for XTOS deprecation and switch to Zephyr native
drivers on imx8/imx8x, remove the ability to build SOF
with XTOS on them.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
@LaurentiuM1234
Copy link
Contributor Author

V2 updates

  1. Fixed commit messages to use imx8/imx8x instead of QM/QXP.
  2. Switched to AMD's rmb in reproducible builds test.

@kv2019i kv2019i merged commit ac4cf61 into thesofproject:main Feb 16, 2024
39 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants