schedule: config to build LL without task rescheduling #9816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a config to instantiate the low-latency scheduler without task rescheduling, given that the operation is optional. Signed-off-by: Johny Lin <[email protected]>
to skip reschedule task for LL scheduler on mt8196 platform. Signed-off-by: Johny Lin <[email protected]>
johnylin76
requested review from
pblaszko,
marcinszkudlinski,
dbaluta,
LaurentiuM1234,
lgirdwood,
plbossart,
mmaka1,
lbetlej and
kv2019i
as code owners
lyakh
reviewed
Feb 7, 2025
| @@ -684,6 +684,11 @@ static int schedule_ll_task_cancel(void *data, struct task *task) | |||
| return 0; | |||
| } | |||
|
|
|||
| #if CONFIG_SCHEDULE_LL_NO_RESCHEDULE_TASK | |||
| /* As a null function pointer */ | |||
| #define reschedule_ll_task ((void*)0) | |||
There was a problem hiding this comment.
Both ways are probably fine. The reason I chose ((void*)0) is because NULL in c is also a macro, and I'm not sure if there is any risk when a macro represents as another macro.
There was a problem hiding this comment.
I'd be very surprised if this didn't work. We certainly have macros using macros like across a dozen or more layers. And this is in a C file, so it won't be included in other files to potentially be used in further macro definitions.
kv2019i
approved these changes
Feb 10, 2025
| rescheduling, given that the operation is optional. Under such cases, | ||
| scheduler_ops::reschedule_task will set to NULL instead, tasks with | ||
| the attempt to reschedule (e.g. DMA trace works) will be relinguished | ||
| directly and return no error. |
There was a problem hiding this comment.
I guess this is ok. One option would be to track the dependency to features (like DMA trace) also in Kconfig, but given this is opt-out, this might be too klungy.
lgirdwood
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a kconfig flag to instantiate the low-latency scheduler without task rescheduling, given that the operation is optional.