Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: mark code as "cold" #9838

Merged
merged 1 commit into from
Feb 18, 2025
Merged

src: mark code as "cold" #9838

merged 1 commit into from
Feb 18, 2025

Conversation

lyakh
Copy link
Collaborator

@lyakh lyakh commented Feb 17, 2025

Mark further initialisation, configuration and freeing paths as "cold."

Mark further initialisation, configuration and freeing paths as
"cold."

Signed-off-by: Guennadi Liakhovetski <[email protected]>
Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, commit title could be Audio: SRC. SRC is an acronym, so use capitals, and I guess we should include a "subsystem" name as first into commit?

@lgirdwood
Copy link
Member

@lyakh can you check internal CI. Thanks !

@lyakh
Copy link
Collaborator Author

lyakh commented Feb 18, 2025

@wszypelt sorry, what can it mean that the "Internal CI" "codecheck" failed but the "build" phase succeeded? I've never seen this before, I thought a successful "codecheck" was a requirement for a "build" to even start?

@lrudyX
Copy link

lrudyX commented Feb 18, 2025

@wszypelt sorry, what can it mean that the "Internal CI" "codecheck" failed but the "build" phase succeeded? I've never seen this before, I thought a successful "codecheck" was a requirement for a "build" to even start?

There was an error, not failed, caused by missing report file. Looks like a temporary problem.

@lyakh
Copy link
Collaborator Author

lyakh commented Feb 18, 2025

@lyakh can you check internal CI. Thanks !

@lgirdwood according to @lrudyX (thanks for checking!) this isn't related

@lyakh
Copy link
Collaborator Author

lyakh commented Feb 18, 2025

Nit, commit title could be Audio: SRC. SRC is an acronym, so use capitals, and I guess we should include a "subsystem" name as first into commit?

@singalsu just checked git log - I see, that's how you prefix commit subjects. I think it's usual not to use capitals there. Elsewhere - in commit text or in comments - yes, definitely, but I think it's rather common not to capitalise prefixes. Looks like we have both styles now, we can agree on one of them, or just decide, that this isn't important enough, I'm fine either way :-)

@lgirdwood lgirdwood merged commit 3d78863 into thesofproject:main Feb 18, 2025
45 of 49 checks passed
@lyakh lyakh deleted the src branch February 18, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants