library_manager: llext: don't try to copy .bss #9846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copying LLEXT modules from DRAM to SRAM we allocate and copy .data and .bss together because they have the same access flags, but .bss doesn't have to be copied, this can in fact generate an error because it isn't present in the ELF image. Only copy valid sections. Reported-by: Tomasz Leman <[email protected]> Signed-off-by: Guennadi Liakhovetski <[email protected]>
lyakh
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
tmleman
approved these changes
Feb 20, 2025
|
CI failures:
|
lgirdwood
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying LLEXT modules from DRAM to SRAM we allocate and copy .data and .bss together because they have the same access flags, but .bss doesn't have to be copied, this can in fact generate an error because it isn't present in the ELF image. Only copy valid sections.