-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed / Refactored majority of Unit (non CI) tests to run green based on current functionality #83
base: fmsentry
Are you sure you want to change the base?
Conversation
@thess updated tests only, to match current functionality. I am not able to run the Integration tests ( |
I guess it is apparent that I do not use these test units or CI as they are from the original project. I do however, appreciate you bringing these up-to-date (more or less). I will merge this after I get a chance to try them out. The original documentation (Wiki) is a bit stale too -- hint, hint. |
The I found it very useful when doing the nomorobo updates to try to do it test-first as it did actually help me find some edge cases that I hadn't accounted for, or where one change broke another. Running at least those ones regularly might also give an indicator when nomorobo or shouldianswer.com services have changed (or just that the test numbers need to change to validate continued functionality) FYI I've made this my "procrastination project" - so when I have something really gnarly in front of me that I need to do, I'll probably just open this one up instead and procrastinate instead... if you see PRs from me it means I'm avoiding real life ;) I'll take a gander at the wiki too next time I need to procrastinate on an urgent but uninteresting thing :) You might want to take a look at the issues and tag some of them with |
I couldn't figure out how to contribute to the wiki. Best I could do was fork this repo and create a wiki there which I can edit, but there is no pull request functionality for wiki. I made a couple of small changes to the install instructions here in my own fork but I couldn't figure out how to apply the changes to yours. |
Wiki source is in https://github.com/thess/callattendant-wiki. Submit PRs there. |
f1c772f
to
6c0de5e
Compare
Tests should now run green with the exception of the
test_webapp
and CI / Integration Tests.