Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed / Refactored majority of Unit (non CI) tests to run green based on current functionality #83

Open
wants to merge 1 commit into
base: fmsentry
Choose a base branch
from

Conversation

telnetdoogie
Copy link
Contributor

Tests should now run green with the exception of the test_webapp and CI / Integration Tests.

@telnetdoogie
Copy link
Contributor Author

telnetdoogie commented Jan 9, 2025

@thess updated tests only, to match current functionality.
Apologies for the false PR earlier, I had included a merge in there from your previous commits, wanted to get this cleaned up to only include my modifications and based from your latest commit in fmsentry.

I am not able to run the Integration tests (test_indicators , test_modem, test_voicemail) based on my dev platform / hardware setup, and I haven't taken a stab at the test_webapp at all. Just wanted to make sure that the majority of logic / function tests were able to run green.

@telnetdoogie telnetdoogie changed the title Fixed majority of Unit (non CI) tests to run green based on current functionality Fixed / Refactored majority of Unit (non CI) tests to run green based on current functionality Jan 10, 2025
@thess
Copy link
Owner

thess commented Jan 10, 2025

I guess it is apparent that I do not use these test units or CI as they are from the original project. I do however, appreciate you bringing these up-to-date (more or less). I will merge this after I get a chance to try them out.

The original documentation (Wiki) is a bit stale too -- hint, hint.

@telnetdoogie
Copy link
Contributor Author

telnetdoogie commented Jan 10, 2025

The test_wepapp test after I looked at it is pretty pointless to be honest, my recommendation would be to just delete that one.

I found it very useful when doing the nomorobo updates to try to do it test-first as it did actually help me find some edge cases that I hadn't accounted for, or where one change broke another. Running at least those ones regularly might also give an indicator when nomorobo or shouldianswer.com services have changed (or just that the test numbers need to change to validate continued functionality)

FYI I've made this my "procrastination project" - so when I have something really gnarly in front of me that I need to do, I'll probably just open this one up instead and procrastinate instead... if you see PRs from me it means I'm avoiding real life ;)

I'll take a gander at the wiki too next time I need to procrastinate on an urgent but uninteresting thing :)

You might want to take a look at the issues and tag some of them with help wanted as well if you think there are some low hanging fruit that folks can help out with.

@telnetdoogie
Copy link
Contributor Author

The original documentation (Wiki) is a bit stale too -- hint, hint.

I couldn't figure out how to contribute to the wiki. Best I could do was fork this repo and create a wiki there which I can edit, but there is no pull request functionality for wiki. I made a couple of small changes to the install instructions here in my own fork but I couldn't figure out how to apply the changes to yours.

@thess
Copy link
Owner

thess commented Jan 12, 2025

Wiki source is in https://github.com/thess/callattendant-wiki.

Submit PRs there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants