Metadata API: remove dateutil requirement #1726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added "dateutil" as a possible argument type for `Metadata.bump_expiration()` as we are already testing for this and implying it should be supported. The problem is that "dateutil" is not added as a nontest requirement and after a discussion, we decided we don't want to add it as well. That's why we decided to remove "dateutil" mentions from the code and not confuse our users we support it. We will create a separate issue discussing the validity of `Metadata.bump_expiration()`. Signed-off-by: Martin Vrachev <[email protected]>
Pull Request Test Coverage Report for Build 1577091651
💛 - Coveralls |
MVrachev
commented
Dec 14, 2021
Comment on lines
-336
to
-344
| # Test whether dateutil.relativedelta works, this provides a much | ||
| # easier to use interface for callers | ||
| delta = relativedelta(days=1) | ||
| timestamp.signed.bump_expiration(delta) | ||
| self.assertEqual(timestamp.signed.expires, datetime(2031, 1, 3, 0, 0)) | ||
| delta = relativedelta(years=5) | ||
| timestamp.signed.bump_expiration(delta) | ||
| self.assertEqual(timestamp.signed.expires, datetime(2036, 1, 3, 0, 0)) | ||
|
|
There was a problem hiding this comment.
This test code is removed as if we don't make timedelta argument of Signed a Union[timedelta, relativedelta] then mypy complains.
jku
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
LGTM.
There are ways to test relativedelta usage without making it explicitly part of the API, and we probably want to do that... but since the expiry API has multiple related issues I think this is fine: let's remove relativedelta code completely for now to get a clean build and look for the correct solution to expiry issue in #1727.
3 tasks
Pull Request Test Coverage Report for Build 1577091651Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 1577091651Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1722
Description of the changes being introduced by the pull request:
I added
dateutilas a possible argument type forSigned.bump_expiration()as we are already testing for this andimplying it should be supported.
The problem is that
dateutilis not added as a nontest requirementand after a discussion, we decided we don't want to add it as well.
That's why we decided to remove
dateutilmentions from the codeand not confuse our users we support it.
We will create a separate issue discussing the validity of
Metadata.bump_expiration().Signed-off-by: Martin Vrachev [email protected]
Please verify and check that the pull request fulfills the following
requirements: