feat: alow getRoles to be async#125
Open
lucasdidur wants to merge 1 commit intothiagobustamante:masterfrom
lucasdidur:master
Open
feat: alow getRoles to be async#125lucasdidur wants to merge 1 commit intothiagobustamante:masterfrom lucasdidur:master
lucasdidur wants to merge 1 commit intothiagobustamante:masterfrom
lucasdidur:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 94.41% 94.41% +<.01%
==========================================
Files 14 14
Lines 1128 1129 +1
Branches 204 204
==========================================
+ Hits 1065 1066 +1
Misses 63 63
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To create a new Service Autenticator for firebase and get roles directly from database, getRoles functions need to be async