Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to tedge-configuration-plugin #2368

Merged

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Oct 24, 2023

Proposed changes

Switch to using tedge-configuration-plugin by default:

  • Use tedge-configuration-plugin in multi-call binary (instead of the c8y-configuration-plugin)
  • Include tedge-configuration-plugin in default packaging (inc
  • Include c8y-configuration-plugin in legacy packaging (to make it easier for some users to build the package themselves)
  • Update system tests

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller force-pushed the package-tedge-configuration-plugin branch from d00f0fc to a2fe336 Compare October 24, 2023 07:46
@reubenmiller reubenmiller added theme:configuration Theme: Configuration management theme:packaging Theme: Packaging and release artefact topics labels Oct 24, 2023
@reubenmiller reubenmiller self-assigned this Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2368 (8a77bb5) into main (77e62aa) will decrease coverage by 0.1%.
Report is 1 commits behind head on main.
The diff coverage is 62.5%.

Additional details and impacted files
Files Coverage Δ
.../tedge_config/src/tedge_config_cli/tedge_config.rs 81.8% <100.0%> (ø)
crates/common/tedge_utils/src/file.rs 67.6% <100.0%> (ø)
crates/core/tedge/src/cli/mod.rs 73.6% <ø> (ø)
crates/extensions/c8y_mapper_ext/src/inventory.rs 82.5% <100.0%> (-0.2%) ⬇️
crates/extensions/tedge_health_ext/src/lib.rs 95.0% <100.0%> (ø)
crates/core/tedge_watchdog/src/systemd_watchdog.rs 20.5% <0.0%> (ø)
crates/core/tedge/src/main.rs 58.3% <0.0%> (ø)

... and 8 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
340 0 3 340 100 1h1m44.449999999s

@reubenmiller
Copy link
Contributor Author

Current test failure is due to #2366

Copy link
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the doc updates will be done in a follow-up PR, as this one is already fairly big.

@reubenmiller
Copy link
Contributor Author

I'm assuming the doc updates will be done in a follow-up PR, as this one is already fairly big.

Yes someone from the team will have to take up the documentation updates required for this in a follow up PR.

Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Only minor comments.

Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@reubenmiller reubenmiller force-pushed the package-tedge-configuration-plugin branch from e4cf7f7 to fc48081 Compare October 26, 2023 14:35
@reubenmiller reubenmiller force-pushed the package-tedge-configuration-plugin branch from fc48081 to 8a77bb5 Compare October 26, 2023 14:35
@reubenmiller reubenmiller temporarily deployed to Test Pull Request October 26, 2023 14:46 — with GitHub Actions Inactive
Copy link
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenmiller reubenmiller merged commit 30a5590 into thin-edge:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:configuration Theme: Configuration management theme:packaging Theme: Packaging and release artefact topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants