Skip to content

Don't install mmh3 dependency at runtime #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vinicentus wants to merge 3 commits into from
Closed

Don't install mmh3 dependency at runtime #51

vinicentus wants to merge 3 commits into from

Conversation

@vinicentus
Copy link

@vinicentus vinicentus commented Nov 17, 2023

This will install mmh3 when installing the package itself, unless pymmh3 is already installed.
I have updated the readme to explain this.

Fixes #39
Fixes #48
Most likely fixes #50

@vinicentus
Copy link
Author

vinicentus commented Nov 17, 2023

Technique taken from here, here and here

@imbeacon imbeacon closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot import TBDeviceMqttClient mmh installation is run every time at startup Importing python module should not trigger package installation

2 participants

@vinicentus @imbeacon