Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All-in-one Login with Oauth Flow #20

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented May 15, 2024

PR-Codex overview

The focus of this PR is to enhance the authentication flow by adding OAuth2 login support and implementing a custom browser for InAppWallet.

Detailed summary

  • Added OAuth2 login support with LoginWithOauth method in InAppWallet
  • Implemented custom browser InAppWalletBrowser for handling OAuth2 login process
  • Introduced IThirdwebBrowser interface for browser interaction

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (d0d24d7) to head (bc20f2f).

❗ Current head bc20f2f differs from pull request most recent head f2ad3ee. Consider uploading reports for the commit f2ad3ee to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   92.35%   95.79%   +3.43%     
==========================================
  Files          16       15       -1     
  Lines        1190     1093      -97     
  Branches      116      103      -13     
==========================================
- Hits         1099     1047      -52     
+ Misses         73       29      -44     
+ Partials       18       17       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit bd059d4 into main May 15, 2024
1 check failed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/oauth-generic branch May 15, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants