Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional 712 utils for SigMint & Forwarder #23

Merged
merged 2 commits into from
May 29, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented May 29, 2024

PR-Codex overview

This PR introduces methods to generate signatures for different token mint requests using EIP712.

Detailed summary

  • Added methods to generate signatures for TokenERC20, TokenERC721, and TokenERC1155 mint requests
  • Implemented typed definitions for each token mint request type
  • Updated method signatures in EIP712.cs and added necessary logic in ContractTypes.cs

The following files were skipped due to too many changes: Thirdweb/Thirdweb.Wallets/EIP712.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (b9f1792) to head (0e6e77e).

Current head 0e6e77e differs from pull request most recent head fa1f681

Please upload reports for the commit fa1f681 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   91.28%   91.91%   +0.63%     
==========================================
  Files          17       18       +1     
  Lines        1377     1485     +108     
  Branches      138      138              
==========================================
+ Hits         1257     1365     +108     
  Misses         94       94              
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 3cf4d7c into main May 29, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/712-sigmint branch May 29, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants