Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native transfer extension #30

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Native transfer extension #30

merged 3 commits into from
Jun 13, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jun 13, 2024

PR-Codex overview

The focus of this PR is to enhance wallet functionality, introducing a transfer method and improving authentication flow.

Detailed summary

  • Added Transfer method to facilitate transfers between wallets
  • Enhanced authentication process in SmartWallet for improved security
  • Updated tests to cover new transfer functionality

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 58.13953% with 18 lines in your changes missing coverage. Please review.

Project coverage is 93.17%. Comparing base (c33a49e) to head (2480579).

Files Patch % Lines
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   93.90%   93.17%   -0.73%     
==========================================
  Files          23       23              
  Lines        1951     1993      +42     
  Branches      219      226       +7     
==========================================
+ Hits         1832     1857      +25     
- Misses         82       99      +17     
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit df96324 into main Jun 13, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/native-transfer branch June 13, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants