Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT, Batching, Performance & Speed + WebGL Fix #36

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jun 18, 2024


PR-Codex overview

The focus of this PR is to add ConfigureAwait(false) to asynchronous method calls for better performance and responsiveness.

Detailed summary

  • Updated Supply property in NFTTypes.cs to accept null values.
  • Added ConfigureAwait(false) to asynchronous method calls in various classes for improved responsiveness.
  • Modified test assertions in NFTExtension.Tests.cs.
  • Added new GetBalance_WithERC20 test in WalletExtension.Tests.cs.
  • Implemented ThirdwebRPCTimer class.
  • Updated GetBalance extension method in ThirdwebWalletExtensions.cs.
  • Added ConfigureAwait(false) to asynchronous methods in various wallet-related classes.

The following files were skipped due to too many changes: Thirdweb/Thirdweb.Wallets/InAppWallet/EmbeddedWallet.Authentication/AWS.cs, Thirdweb/Thirdweb.Storage/ThirdwebStorage.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/EmbeddedWallet/EmbeddedWallet.EmailOTP.cs, Thirdweb/Thirdweb.Contracts/ThirdwebContract.cs, Thirdweb/Thirdweb.RPC/ThirdwebRPC.cs, Thirdweb/Thirdweb.NFT/ThirdwebNFTExtensions.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/EmbeddedWallet/EmbeddedWallet.Misc.cs, Thirdweb/Thirdweb.Transactions/ThirdwebTransaction.cs, Thirdweb/Thirdweb.Contracts/ThirdwebContractExtensions.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/EmbeddedWallet.Authentication/Server.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper merged commit d1385b5 into main Jun 20, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/configure-await branch June 20, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant