Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS REST Integration // Remove SDK Dependency #38

Merged
merged 12 commits into from
Jun 26, 2024
Merged

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jun 21, 2024

PR-Codex overview

This PR focuses on updating dependencies, improving exception handling, and enhancing wallet generation in the codebase.

Detailed summary

  • Updated package versions for Nethereum.Signer.EIP712 and Portable.BouncyCastle.
  • Removed Amazon.Extensions.CognitoAuthentication and AWSSDK.Lambda packages.
  • Improved exception handling in VerificationException class.
  • Enhanced wallet generation in various test files.
  • Modified timeout duration in ThirdwebRPC and ThirdwebRPCTimer classes.
  • Added platform parameter in FetchHeadlessOauthLoginLinkAsync method.
  • Refactored PrivateKeyWallet creation to Generate method in multiple test files.
  • Improved request timeout handling in ThirdwebStorage and BundlerRequest methods.
  • Added a lock object for thread safety in ThirdwebRPCTimer class.
  • Updated user prompts and comments in Program.cs.

The following files were skipped due to too many changes: Thirdweb.Console/Program.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/IThirdwebBrowser.cs, Thirdweb/Thirdweb.Wallets/ThirdwebWalletExtensions.cs, Thirdweb.Tests/Thirdweb.Transactions.Tests.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/InAppWallet.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/InAppWalletBrowser.cs, Thirdweb.Tests/Thirdweb.ERC20Extension.Tests.cs, Thirdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs, Thirdweb/Thirdweb.Transactions/ThirdwebTransaction.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/EmbeddedWallet/EmbeddedWallet.Misc.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/EmbeddedWallet.Encryption/EmbeddedWallet.Cryptography.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/EmbeddedWallet.Encryption/Secrets.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/EmbeddedWallet.Authentication/Server.cs, Thirdweb/Thirdweb.Wallets/InAppWallet/EmbeddedWallet.Authentication/AWS.cs, Thirdweb/Thirdweb.Contracts/ThirdwebContractExtensions.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 64.07767% with 37 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d1385b5). Learn more about missing BASE report.

Files Patch % Lines
Thirdweb/Thirdweb.RPC/ThirdwebRPCTimer.cs 31.57% 12 Missing and 1 partial ⚠️
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 50.00% 7 Missing and 4 partials ⚠️
...b/Thirdweb.Contracts/ThirdwebContractExtensions.cs 72.72% 9 Missing ⚠️
...allet/Thirdweb.AccountAbstraction/BundlerClient.cs 57.14% 3 Missing ⚠️
Thirdweb/Thirdweb.NFT/ThirdwebNFTExtensions.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage        ?   89.87%           
=======================================
  Files           ?       27           
  Lines           ?     2341           
  Branches        ?      275           
=======================================
  Hits            ?     2104           
  Misses          ?      178           
  Partials        ?       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 255f766 into main Jun 26, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/aws-rest branch June 26, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants