Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & Organize Tests #42

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix & Organize Tests #42

merged 1 commit into from
Jul 1, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jul 1, 2024

PR-Codex overview

This PR focuses on improving test performance and code structure.

Detailed summary

  • Updated test timeouts to 120000 milliseconds
  • Modified cache duration from 250 to 25 milliseconds
  • Refactored RPC response deserialization
  • Reorganized test namespaces
  • Added IsDeploying property to SmartWallet
  • Improved deployment logic in SmartWallet

The following files were skipped due to too many changes: Thirdweb.Tests/Thirdweb.Contracts.Tests.cs, Thirdweb.Tests/Thirdweb.RPC.Tests.cs, Thirdweb.Tests/Thirdweb.Storage.Tests.cs, Thirdweb.Tests/Thirdweb.SmartWallet.Tests.cs, Thirdweb.Tests/Thirdweb.Http.Tests.cs, Thirdweb.Tests/Thirdweb.PrivateKeyWallet.Tests.cs, Thirdweb.Tests/Thirdweb.Utils.Tests.cs, Thirdweb.Tests/Thirdweb.Transactions.Tests.cs, Thirdweb.Tests/Thirdweb.Extensions/Thirdweb.Extensions.Tests.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.

Project coverage is 90.37%. Comparing base (58015f2) to head (4abeb21).
Report is 3 commits behind head on main.

Files Patch % Lines
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 26.66% 6 Missing and 5 partials ⚠️
Thirdweb/Thirdweb.RPC/ThirdwebRPC.cs 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   90.59%   90.37%   -0.23%     
==========================================
  Files          24       24              
  Lines        2903     2919      +16     
  Branches      380      383       +3     
==========================================
+ Hits         2630     2638       +8     
- Misses        200      206       +6     
- Partials       73       75       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit d3170ff into main Jul 1, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/test-fixes branch July 1, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants