Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain Fetch Util #43

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Chain Fetch Util #43

merged 1 commit into from
Jul 5, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jul 5, 2024

PR-Codex overview

This PR introduces a new method FetchThirdwebChainDataAsync to fetch chain data asynchronously. It also adds related classes for JSON deserialization and updates tests accordingly.

Detailed summary

  • Added FetchThirdwebChainDataAsync method to fetch chain data asynchronously
  • Introduced classes for JSON deserialization
  • Updated tests for the new method

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.28%. Comparing base (dae01ad) to head (7f1b27c).

Files Patch % Lines
Thirdweb/Thirdweb.Utils/Utils.cs 63.15% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   90.37%   90.28%   -0.09%     
==========================================
  Files          24       25       +1     
  Lines        2919     2975      +56     
  Branches      383      384       +1     
==========================================
+ Hits         2638     2686      +48     
- Misses        206      212       +6     
- Partials       75       77       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 0167c29 into main Jul 5, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/chain-fetch branch July 5, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants