Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: authentication for analytics #852

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 20, 2025

PR-Codex overview

This PR updates the ANALYTICS_DEFAULT_HEADERS object in src/shared/utils/usage.ts to use the env variable for ENGINE_VERSION and adds a new header for THIRDWEB_API_SECRET_KEY.

Detailed summary

  • Changed the value of x-sdk-version from process.env.ENGINE_VERSION to env.ENGINE_VERSION.
  • Added a new header x-secret-key with the value env.THIRDWEB_API_SECRET_KEY.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

zeet-co bot commented Feb 20, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-ph-cal-e4576c.engine-aws-usw2.zeet.app before merging 😉

@arcoraven arcoraven merged commit ba92cc8 into main Feb 20, 2025
6 of 7 checks passed
@arcoraven arcoraven deleted the ph/call-analytics-with-secret-key branch February 20, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant