Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing else block #853

Merged
merged 1 commit into from
Feb 21, 2025
Merged

add missing else block #853

merged 1 commit into from
Feb 21, 2025

Conversation

d4mr
Copy link
Member

@d4mr d4mr commented Feb 21, 2025

PR-Codex overview

This PR focuses on modifying error handling in the insert-transaction.ts file. It adds logic to rethrow errors that are not instances of WalletDetailsError, ensuring that only specific errors are ignored.

Detailed summary

  • Added an else block to rethrow errors that are not instances of WalletDetailsError.
  • Removed the redundant comment and line that rethrew the error.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

zeet-co bot commented Feb 21, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-pb-fix-3cdc14.engine-aws-usw2.zeet.app before merging 😉

@d4mr d4mr merged commit b952e62 into main Feb 21, 2025
5 of 6 checks passed
@d4mr d4mr deleted the pb/fix-insert-transaction-v4 branch February 21, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant