Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non sbw flow for AA atomic transactions #859

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

d4mr
Copy link
Member

@d4mr d4mr commented Feb 28, 2025

PR-Codex overview

This PR focuses on enhancing the sendTransactionBatchAtomicRoute function by improving type imports and modifying the structure of the transaction object being inserted, particularly in relation to user operations.

Detailed summary

  • Changed the import of Address and Hex from thirdweb to include getAddress.
  • Modified the sendTransactionBatchAtomicRoute function signature to include a new line for better readability.
  • Updated the inserted transaction structure to conditionally include isUserOp and signerAddress based on hasSmartHeaders.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

zeet-co bot commented Feb 28, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-pb-fix-968171.engine-aws-usw2.zeet.app before merging 😉

@d4mr d4mr requested a review from joaquim-verges February 28, 2025 15:00
@d4mr d4mr merged commit 1b28f09 into main Feb 28, 2025
6 checks passed
@d4mr d4mr deleted the pb/fix-send-transaction-batch-atomic branch February 28, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant