Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hex transaction types in fromTransactionType #861

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 3, 2025

Changes

How this PR will be tested

  • Open the dashboard and click X. Result: A modal should appear.
  • Call the /foo/bar API. Result: Returns 200 with "baz" in the response body.

Output

(Example: Screenshot/GIF for UI changes, cURL output for API changes)


PR-Codex overview

This PR modifies the src/shared/utils/sdk.ts file by enhancing the fromTransactionType function and removing the toTransactionType function, streamlining transaction type handling.

Detailed summary

  • Added hexToNumber and isHex imports from thirdweb.
  • Updated fromTransactionType to convert hex transaction types using hexToNumber.
  • Removed the entire toTransactionType function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

zeet-co bot commented Mar 3, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://engine-v3-test-instance-yl1c-supp-e82f2b.engine-aws-usw2.zeet.app before merging 😉

Copy link

zeet-co bot commented Mar 3, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-suppor-66cac3.engine-aws-usw2.zeet.app before merging 😉

@joaquim-verges joaquim-verges marked this pull request as ready for review March 3, 2025 22:37
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Member Author

joaquim-verges commented Mar 3, 2025

Merge activity

  • Mar 3, 6:10 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Mar 3, 6:10 PM EST: A user merged this pull request with Graphite.

@joaquim-verges joaquim-verges merged commit e860bba into main Mar 3, 2025
8 checks passed
@joaquim-verges joaquim-verges deleted the Support_hex_transaction_types_in_fromTransactionType branch March 3, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants