-
Notifications
You must be signed in to change notification settings - Fork 519
Deprecate Pack #6781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Deprecate Pack #6781
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we split this into multiple PRs?
- disable pack in dashboard
- remove pack from SDK (needs AT LEAST a minor version, should REALISTICALLY be a major version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would not remove the pack code entirely.
we still have the Chainlink version which still works and uses the same SDK code
Or I can just remove the deploy functions from export for now? @joaquim-verges |
PR-Codex overview
This PR focuses on the removal of various files and code related to the
Pack
extension and its associated functionalities within thethirdweb
project, streamlining the codebase by eliminating unused components.Detailed summary
Pack
extension, including:pack.ts
createNewPack.ts
deploy-pack.ts
forwarderContractId
to always be"Forwarder"
.thirdweb.eth/Pack
from the explore data.PackContractParams
,DeployPackContractOptions
, anddeployPackContract
.