Skip to content

Update dependencies and add atomicRequired option to sendCalls #6786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Apr 21, 2025

Update Dependencies

This PR updates several dependencies to their latest versions:

  • Upgraded @hey-api/openapi-ts from 0.66.1 to 0.66.5 in the insight package
  • Removed tslib dependency from the insight package
  • Updated @noble/curves from 1.8.1 to 1.8.2
  • Updated @noble/hashes from 1.7.1 to 1.7.2
  • Updated ox from 0.6.12 to 0.7.0
  • Updated viem from 2.24.3 to 2.27.2

Additionally, added atomicRequired parameter to the EIP-5792 wallet implementation with a default value of false to better align with the EIP specification.


PR-Codex overview

This PR introduces the atomicRequired property to several TypeScript files in the thirdweb package, updates dependencies, and modifies configuration files. It primarily enhances wallet functionality by ensuring atomic transaction capabilities.

Detailed summary

  • Added atomicRequired property to version in types.ts and send-calls.ts.
  • Updated test cases in send-calls.test.ts to include atomicRequired.
  • Increased size limit in .size-limit.json from 52 kB to 53 kB.
  • Updated viem version from 2.24.3 to 2.27.2 in package.json and pnpm-lock.yaml.
  • Updated @hey-api/openapi-ts from 0.66.1 to 0.66.5 in package.json and pnpm-lock.yaml.
  • Ensured consistency in files array formatting in package.json under insight.
  • Adjusted typesVersions paths in package.json for thirdweb.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 4:28pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 4:28pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 4:28pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 4:28pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 4:28pm

Copy link

changeset-bot bot commented Apr 21, 2025

⚠️ No Changeset found

Latest commit: 12ff6e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 21, 2025
Copy link
Member Author

jnsdls commented Apr 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review April 21, 2025 18:54
@jnsdls jnsdls requested review from a team as code owners April 21, 2025 18:54
Copy link

socket-security bot commented Apr 21, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​noble/​curves@​1.8.210010010086100
Updated@​hey-api/​openapi-ts@​0.66.1 ⏵ 0.66.598 +1100100 +196100
Addedox@​0.7.01001009997100

View full report

Copy link
Contributor

github-actions bot commented Apr 21, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.91 KB (+0.35% 🔺) 1.1 s (+0.35% 🔺) 530 ms (+123.54% 🔺) 1.6 s
thirdweb (cjs) 143.44 KB (+3.35% 🔺) 2.9 s (+3.35% 🔺) 879 ms (+34.52% 🔺) 3.8 s
thirdweb (minimal + tree-shaking) 5.64 KB (+0.56% 🔺) 113 ms (+0.56% 🔺) 156 ms (+841.47% 🔺) 269 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 58 ms (+730.21% 🔺) 68 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (-0.42% 🔽) 387 ms (-0.42% 🔽) 260 ms (+393.7% 🔺) 647 ms

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (c03734a) to head (12ff6e4).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6786   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         896      896           
  Lines       56940    56941    +1     
  Branches     3943     3944    +1     
=======================================
+ Hits        31420    31421    +1     
  Misses      25424    25424           
  Partials       96       96           
Flag Coverage Δ
packages 55.18% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...ackages/thirdweb/src/wallets/eip5792/send-calls.ts 82.97% <100.00%> (+0.18%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit ec5362b into main Apr 23, 2025
24 checks passed
@joaquim-verges joaquim-verges deleted the Update_dependencies_and_add_atomicRequired_option_to_sendCalls branch April 23, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants