Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 19, 2025


PR-Codex overview

This PR focuses on enhancing wallet integration for bridge widgets by customizing wallet options and updating the default wallet list. It introduces new wallet configurations and story examples for better user experience.

Detailed summary

  • Removed in-app wallet from the default wallet list.
  • Added CustomWallets component in multiple story files to allow specific wallet selection.
  • Updated getDefaultWalletsForBridgeComponents to include new wallets.
  • Enhanced FundWallet, SwapUI, and TransactionPayment components to support custom wallet options.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 19, 2025

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2025

🦋 Changeset detected

Latest commit: 304e4e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
thirdweb Minor
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch
wagmi-inapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs-v2 Ready Ready Preview, Comment Dec 19, 2025 7:40pm
nebula Ready Ready Preview, Comment Dec 19, 2025 7:40pm
thirdweb_playground Ready Ready Preview, Comment Dec 19, 2025 7:40pm
thirdweb-www Ready Ready Preview, Comment Dec 19, 2025 7:40pm
wallet-ui Ready Ready Preview, Comment Dec 19, 2025 7:40pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mny-348

Comment @coderabbitai help to get the list of available commands and usage tips.

@MananTank MananTank marked this pull request as ready for review December 19, 2025 18:23
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 19, 2025
@MananTank MananTank requested a review from a team as a code owner December 19, 2025 18:23
@MananTank MananTank requested a review from a team as a code owner December 19, 2025 18:23
Copy link
Member Author

MananTank commented Dec 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 20.68966% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.24%. Comparing base (fdd2557) to head (304e4e5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/wallets/defaultWallets.ts 26.66% 11 Missing ⚠️
...es/thirdweb/src/react/web/ui/Bridge/FundWallet.tsx 14.28% 6 Missing ⚠️
...web/src/react/web/ui/Bridge/TransactionPayment.tsx 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8579      +/-   ##
==========================================
- Coverage   53.26%   53.24%   -0.03%     
==========================================
  Files         922      922              
  Lines       61386    61415      +29     
  Branches     4026     4026              
==========================================
+ Hits        32696    32699       +3     
- Misses      28593    28618      +25     
- Partials       97       98       +1     
Flag Coverage Δ
packages 53.24% <20.68%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
...es/thirdweb/src/react/web/ui/Bridge/FundWallet.tsx 6.32% <14.28%> (+0.11%) ⬆️
...web/src/react/web/ui/Bridge/TransactionPayment.tsx 6.66% <14.28%> (+0.14%) ⬆️
packages/thirdweb/src/wallets/defaultWallets.ts 60.60% <26.66%> (-39.40%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 19, 2025

Merge activity

…ge widgets (#8579)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing wallet integration in bridge components by introducing custom wallet options and modifying default wallet selections for various widgets.

### Detailed summary
- Removed in-app wallet from default wallet list for bridge widgets.
- Added `CustomWallets` component in `BuyWidget.stories.tsx` and `SwapWidget.stories.tsx`.
- Implemented `getDefaultWalletsForBridgeComponents` to return a list of wallets.
- Updated `FundWallet`, `SwapUI`, and `TransactionPayment` components to use custom wallet options.
- Introduced new wallet options in `TransactionWidget.stories.tsx`.
- Added `CustomWallets` functionality in `BridgeWidget` stories.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants