[MNY-316] SDK: directly show token selection after wallet connection in bridge widgets #8580

MananTank · 2025-12-19T19:52:54Z

PR-Codex overview

This PR modifies the behavior of the wallet connection process within the WalletSwitcherConnectionScreen. Upon connecting a wallet, it now directly transitions to the token selection screen, bypassing the intermediate "Choose Payment" screen.

Detailed summary

Updated onConnect function to remove the call to props.onBack(), allowing direct navigation to the token selection screen after wallet connection.
Updated documentation to reflect the change in user flow for the wallet connection process in bridge widgets.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Streamlined wallet connection in bridge widgets: after connecting a wallet on the Choose Payment screen, the flow now advances directly to token selection instead of returning to or redisplaying the payment screen.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

vercel · 2025-12-19T19:52:57Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
docs-v2	Ready	Preview, Comment	Dec 19, 2025 8:17pm
nebula	Ready	Preview, Comment	Dec 19, 2025 8:17pm
thirdweb_playground	Ready	Preview, Comment	Dec 19, 2025 8:17pm
thirdweb-www	Ready	Preview, Comment	Dec 19, 2025 8:17pm
wallet-ui	Ready	Preview, Comment	Dec 19, 2025 8:17pm

linear · 2025-12-19T19:52:58Z

MNY-316 When connecting a wallet in the Pay with crypto/Pay with fiat screen, auto switch to the next screen on successful connection

changeset-bot · 2025-12-19T19:52:59Z

🦋 Changeset detected

Latest commit: 0ff8b9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/nebula	Patch
@thirdweb-dev/wagmi-adapter	Patch
wagmi-inapp	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-12-19T19:53:02Z

Walkthrough

Adds a changeset entry and modifies the wallet connection handler so connecting a wallet on the Choose Payment screen no longer triggers back-navigation; the onConnect path now selects the wallet and proceeds to the next (token selection) screen.

Changes

Cohort / File(s)	Summary
Changeset metadata `/.changeset/heavy-clowns-stay.md`	New patch release entry documenting the UI flow change for wallet connection on payment screens.
Wallet connection flow `packages/thirdweb/src/react/web/ui/ConnectWallet/screens/WalletSwitcherConnectionScreen.tsx`	Removed invocation of `onBack()` from the `onConnect` handler; `onConnect` now calls `props.onSelect(w)` only, so the flow proceeds without returning to the Choose Payment screen.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Areas to pay attention to:
- WalletSwitcherConnectionScreen.tsx — verify that removing onBack() does not break other navigation assumptions or leave any dangling UI state.
- Integration points where the Choose Payment / bridge widgets expect the previous back-navigation behavior (ensure callers handle the new forward-only flow).
- Changeset file — confirm wording and versioning are correct.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description includes a PR-Codex overview but does not follow the repository's template structure with required sections like 'Notes for the reviewer' and 'How to test'.	Add sections for 'Notes for the reviewer' and 'How to test' to follow the repository's template, or clarify testing approach and any important review notes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the back-navigation flow after wallet connection to allow direct advancement to token selection in bridge widgets.
Linked Issues check	✅ Passed	The code changes directly address the linked issue MNY-316 by removing the onBack() call in onConnect, enabling automatic navigation to token selection after wallet connection as required.
Out of Scope Changes check	✅ Passed	All changes are directly related to the stated objective: modifying WalletSwitcherConnectionScreen to remove back-navigation behavior and updating the changeset, with no unrelated modifications detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch mny-316

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9f9ce40 and 0ff8b9f.

📒 Files selected for processing (2)

.changeset/heavy-clowns-stay.md (1 hunks)
packages/thirdweb/src/react/web/ui/ConnectWallet/screens/WalletSwitcherConnectionScreen.tsx (0 hunks)

💤 Files with no reviewable changes (1)

packages/thirdweb/src/react/web/ui/ConnectWallet/screens/WalletSwitcherConnectionScreen.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Unit Tests
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: Build Packages
GitHub Check: Lint Packages
GitHub Check: Size
GitHub Check: Analyze (javascript)

🔇 Additional comments (2)

.changeset/heavy-clowns-stay.md (2)

1-5: Changeset is properly formatted and aligns with PR objectives.

The changeset entry is correctly structured with proper YAML front matter and accurately describes the UX flow change. Marking this as a patch release is appropriate for the bug fix.

5-5: Implementation verified and matches changeset description.

The component file exists and correctly implements the described behavior. When a wallet is connected via WalletSwitcherConnectionScreen, the onConnect handler calls props.onSelect(wallet) (not onBack()), which directs users to the token selection screen via handleWalletSelected. Error handling for wallet connection failures is intact through the usePaymentMethods hook and handlePaymentMethodSelected function with try-catch logic. The onSelect() call is properly parameterized with the wallet argument. No unintended side effects are introduced.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

MananTank · 2025-12-19T19:53:13Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-12-19T19:58:56Z

size-limit report 📦

Path	Size
@thirdweb-dev/nexus (esm)	105.66 KB (0%)
@thirdweb-dev/nexus (cjs)	319.47 KB (0%)

codecov · 2025-12-19T19:59:18Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.24%. Comparing base (304e4e5) to head (0ff8b9f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8580   +/-   ##
=======================================
  Coverage   53.24%   53.24%           
=======================================
  Files         922      922           
  Lines       61415    61414    -1     
  Branches     4026     4026           
=======================================
  Hits        32699    32699           
+ Misses      28618    28617    -1     
  Partials       98       98

Flag	Coverage Δ
packages	`53.24% <ø> (+<0.01%)`	⬆️

Files with missing lines	Coverage Δ
...tWallet/screens/WalletSwitcherConnectionScreen.tsx	`11.11% <ø> (+0.20%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

graphite-app · 2025-12-19T20:06:18Z

Merge activity

Dec 19, 8:06 PM UTC: MananTank added this pull request to the Graphite merge queue.
Dec 19, 8:18 PM UTC: Merged by the Graphite merge queue.

…in bridge widgets (#8580)   --- ## PR-Codex overview This PR modifies the behavior of the wallet connection process in the `WalletSwitcherConnectionScreen`. After a wallet is connected, it skips the "Choose Payment" screen and directly moves to the token selection screen, enhancing user experience in bridge widgets. ### Detailed summary - Updated the `onConnect` function to remove the call to `props.onBack()`, preventing the return to the "Choose Payment" screen. - Changed the flow to directly transition to the token selection screen after wallet connection. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit * **Bug Fixes** * Improved wallet connection flow in bridge widgets. After connecting a wallet on the Choose Payment screen, users are now directed directly to token selection instead of returning to the payment screen. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>

github-actions bot assigned MananTank Dec 19, 2025

MananTank marked this pull request as ready for review December 19, 2025 19:53

MananTank requested review from a team as code owners December 19, 2025 19:53

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 19, 2025

vercel bot deployed to Preview – wallet-ui December 19, 2025 19:56 View deployment

vercel bot deployed to Preview – nebula December 19, 2025 19:56 View deployment

vercel bot deployed to Preview – thirdweb_playground December 19, 2025 19:59 View deployment

vercel bot deployed to Preview – thirdweb-www December 19, 2025 20:02 View deployment

vercel bot deployed to Preview – docs-v2 December 19, 2025 20:06 View deployment

graphite-app bot force-pushed the mny-316 branch from 9f9ce40 to 0ff8b9f Compare December 19, 2025 20:06

vercel bot deployed to Preview – wallet-ui December 19, 2025 20:07 View deployment

vercel bot deployed to Preview – thirdweb_playground December 19, 2025 20:07 View deployment

vercel bot deployed to Preview – nebula December 19, 2025 20:08 View deployment

vercel bot deployed to Preview – thirdweb-www December 19, 2025 20:14 View deployment

vercel bot deployed to Preview – docs-v2 December 19, 2025 20:17 View deployment

graphite-app bot merged commit 0ff8b9f into main Dec 19, 2025
25 checks passed

graphite-app bot deleted the mny-316 branch December 19, 2025 20:18

joaquim-verges mentioned this pull request Dec 19, 2025

Version Packages #8554

Open

vercel bot deployed to Production – wallet-ui December 19, 2025 20:21 View deployment

vercel bot deployed to Production – nebula December 19, 2025 20:21 View deployment

vercel bot deployed to Production – thirdweb_playground December 19, 2025 20:23 View deployment

vercel bot deployed to Production – thirdweb-www December 19, 2025 20:26 View deployment

vercel bot deployed to Production – docs-v2 December 19, 2025 20:30 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MNY-316] SDK: directly show token selection after wallet connection in bridge widgets #8580

[MNY-316] SDK: directly show token selection after wallet connection in bridge widgets #8580

MananTank commented Dec 19, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

linear bot commented Dec 19, 2025

Uh oh!

changeset-bot bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 19, 2025 •

edited

Loading

Review ran into problems

Uh oh!

MananTank commented Dec 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[MNY-316] SDK: directly show token selection after wallet connection in bridge widgets #8580

[MNY-316] SDK: directly show token selection after wallet connection in bridge widgets #8580

Conversation

MananTank commented Dec 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

vercel bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Dec 19, 2025

Uh oh!

changeset-bot bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Review ran into problems

Uh oh!

MananTank commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MananTank commented Dec 19, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Dec 19, 2025 •

edited

Loading

changeset-bot bot commented Dec 19, 2025 •

edited

Loading

coderabbitai bot commented Dec 19, 2025 •

edited

Loading

MananTank commented Dec 19, 2025 •

edited

Loading

github-actions bot commented Dec 19, 2025 •

edited

Loading

codecov bot commented Dec 19, 2025 •

edited

Loading

graphite-app bot commented Dec 19, 2025 •

edited

Loading