Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Wallet Visual Update #19

Merged
merged 7 commits into from
Feb 3, 2023
Merged

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Feb 2, 2023

Little visual update, colors outlines and added balance + current network.
I like how this looks now, but we can wait until we get updated chain icons to display if you like.
As for switching networks, I'm not sure it's the best idea for a game connect wallet prefab as most games will be on a specific chain + will require tinkering with the prefab to remove it.
Switching network as a separate prefab later on perhaps?

@0xFirekeeper 0xFirekeeper marked this pull request as draft February 2, 2023 17:09
@0xFirekeeper
Copy link
Member Author

Will add Prefab_SwitchNetwork as a separate prefab and append it to connect wallet so people can just set it inactive if they don't want it. It'll be on a simple > icon near current network.

Switching Network + QOL updates + Supported Chains Inspector + Canvas Scaling
@0xFirekeeper 0xFirekeeper marked this pull request as ready for review February 2, 2023 19:40
@0xFirekeeper
Copy link
Member Author

  • Chain enum instead of strings in the editor, has chain ID built in, and a dictionary in case you need the string identifier, in ThirdwebManager
  • Added switching networks to the connect wallet prefab, there's a bool on whether you want to support it or not which auto turns off its UI
  • Added supported networks to ThirdwebManager, when switching network only those will display
  • Prefab_NFTLoader now scales with the screen
  • Other minor improvements

Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of visual things:

  • on the connected state, the button + fonts feel a bit too small
  • the background color of the connected state is too close to the header color in the scene, making it hard to see (maybe needs a brighter border?)
  • on the nft loader, if you resize too small, then completely disappears, should probably have a min width of 1 column worth?

Arbitrum = 42161,
ArbitrumGoerli = 421613,
Binance = 56,
BinanceTestnet = 97
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceee

@0xFirekeeper
Copy link
Member Author

Updated and restructured a little

@joaquim-verges
Copy link
Member

@0xFirekeeper a bit too much to have all the chain icons i think, can we just keep the ones from the chains we support, and maybe only the high res version for each?

@joaquim-verges
Copy link
Member

joaquim-verges commented Feb 3, 2023

last thing i noticed too : on the dropdown when connected, the current network still has the placeholder icon

Screen Shot 2023-02-02 at 7 54 52 PM

@0xFirekeeper
Copy link
Member Author

Ah good catch, fixing

@0xFirekeeper
Copy link
Member Author

Should be good now

@joaquim-verges joaquim-verges merged commit 193bad8 into main Feb 3, 2023
@joaquim-verges joaquim-verges deleted the firekeeper/connect-upgrade branch February 3, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants