Skip to content
This repository was archived by the owner on Mar 3, 2020. It is now read-only.

Remove deprecated functionality#801

Open
jferris wants to merge 5 commits into
masterfrom
jf-remove-deprecated-behavior
Open

Remove deprecated functionality#801
jferris wants to merge 5 commits into
masterfrom
jf-remove-deprecated-behavior

Conversation

@jferris

@jferris jferris commented Jun 26, 2015

Copy link
Copy Markdown
Contributor
  • Remove old, non-standard driver methods
  • Remove non-global config methods
  • Remove access to browser instance
  • Remove support commands for removed methods
  • Remove support for Qt 4

* Remove old, non-standard driver methods
* Remove non-global config methods
* Remove access to browser instance
* Remove support commands for removed methods
* Remove support for Qt 4
@jferris

jferris commented Jun 26, 2015

Copy link
Copy Markdown
Contributor Author

Resolves #759 and #760.

@jferris jferris added this to the 2.0.0 milestone Jun 26, 2015
Comment thread .travis.yml Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we add qt5-default to this list, we should be able to omit the QMAKE environment variable on line 14.

@mhoran

mhoran commented Jun 28, 2015

Copy link
Copy Markdown
Collaborator

This looks great. I pushed up a few additional changes to the branch. As discussed in #652, we'll now raise an UnhandledModalError when a modal is not explicitly accepted or dismissed. I also removed some dead code. By installing the qt5-default package, there's no need to set the QMAKE environment variable.

We don't support Qt 4 anymore.
@mhoran mhoran force-pushed the jf-remove-deprecated-behavior branch from 61a6dcc to a2952d5 Compare June 28, 2015 01:47
@amenzhinsky

Copy link
Copy Markdown

And what about global fonts overriding? I expected it to be removed when update to qt5

https://github.com/thoughtbot/capybara-webkit/blob/master/src/WebPage.cpp#L116

@jferris

jferris commented Aug 17, 2015

Copy link
Copy Markdown
Contributor Author

@amenzhinsky I opened #761 to handle fonts separately from the deprecated functionality.

@brunoarueira

Copy link
Copy Markdown

hey @jferris, Are there any plans about a release 2.0?

@jferris

jferris commented May 10, 2016

Copy link
Copy Markdown
Contributor Author

Are there any plans about a release 2.0?

I think we will likely release a 2.0 that removes deprecated functionality and is somewhat slimmer, but the main priority is currently to figure out what to do now that QtWebKit is deprecated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants