posit subtraction fixed #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to look into this issue. However, the proposed fix doesn’t actually resolve the underlying problem—it just bypasses it with a conditional check. While this may appear to "work" in a narrow case, it doesn’t address the root cause and could lead to unexpected behavior elsewhere. If you’d like to work on this, I’d encourage you to dig deeper into why the bug occurs and propose a solution that properly fixes the logic rather than working around it. Please revise the PR with a more robust fix, or if you’re unable to do so, we can reassign the issue. Looking forward to your updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the posit subtraction operation
closes #10