-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using generateString in all scripts that deploy a machine #3822
base: development
Are you sure you want to change the base?
Changes from 1 commit
88715bd
1dbc649
61b8aa5
a700aeb
d36709c
b454c8b
2cb4b22
59b5490
1f00f15
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we use generateString for qsfs_name? |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import { AddWorkerModel, Features, FilterOptions } from "../../src"; | ||
import { AddWorkerModel, Features, FilterOptions, generateString } from "../../src"; | ||
import { getClient } from "../client_loader"; | ||
import { log } from "../utils"; | ||
|
||
|
@@ -26,7 +26,7 @@ async function deleteWorker(client, worker) { | |
} | ||
|
||
async function main() { | ||
const name = "testk8s"; | ||
const name = "k8s" + generateString(8); | ||
const grid3 = await getClient(`kubernetes/${name}`); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add a comment for the user to change the name to an existing cluster name so he can add the worker to it |
||
|
||
const workerQueryOptions: FilterOptions = { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of consistency, use a random network name here too