Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridClient:Dynamic_SingleVM: enhance the script #3846

Merged
merged 5 commits into from
Feb 2, 2025

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Jan 30, 2025

Description

the issue maybe related to the network name; at that run that there is another network with the same name but not configured to support myceluim; this should be solved in #3822
but currently we enhanced the script and the workflow is passed
support features and ping node

Changes

  • add myceluim configuration
  • add features to the node qurey
  • use pingNode to select a reachable node

Related Issues

#3834

Tested Scenarios

deployed a dynamic single vm on qa
image

https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/13051502010/job/36412609964 qa workflow passed

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

  • Preliminary Checks
    • Does it completely address the issue linked?
    • What about edge cases?
    • Does it meet the specified acceptance criteria?
    • Are there any unintended side effects?
    • Does the PR adhere to the team's coding conventions, style guides, and best practices?
    • Does it integrate well with existing features?
    • Does it impact the overall performance of the application?
    • Are there any bottlenecks or slowdowns?
    • Has it been optimized for efficiency?
    • Has it been adequately tested with unit, integration, and end-to-end tests?
    • Are there any known defects or issues?
    • Is the code well-documented?
    • Are changes to documentation reflected in the code?

UI Checks:

  • UI Checks
    • If a UI design is provided/ does it follow it?
    • Does every button work?
    • Is the data displayed logical? Is it what you expected?
    • Does every validation work?
    • Does this interface feel intuitive?
    • What about slow network? Offline?
    • What if the gridproxy/graphql/chain is failing?
    • What would a first time user have a hard time navigating here?

Code Quality Checks:

  • Code Quality Checks
    • Code formatted/linted? Are there unused imports? .. etc
    • Is there redundant/repeated code?
    • Are there conditionals that are always true or always false?
    • Can we write this more concisely?
    • Can we reuse this code? If yes, where?
    • Will the changes be easy to maintain and update in the future?
    • Can this code become too complex to understand for other devs?
    • Can this code cause future integration problems?

Testing Checklist

  • Does it Meet the specified acceptance criteria.
  • Test if changes can affect any other functionality.
  • Tested with unit, integration, and end-to-end tests.
  • Tested the un-happy path and rollback scenarios.
  • Documentation updated to meet the latest changes.
  • Check automated tests working successfully with the changes.
  • Can be covered by automated tests.

General Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@samaradel samaradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got this error even my twin id is verified
image

@0oM4R
Copy link
Contributor Author

0oM4R commented Jan 30, 2025

got this error even my twin id is verified image

not sure but it is not related at all, Please try again with another twin and if issue still exists, open an issue;
and for the current issue, the workflow passes on qa

@maayarosama
Copy link
Contributor

Should we exclude node 11 for now so the test can pass on Devnet?

0oM4R added 3 commits February 2, 2025 13:16
- use the pinged node in machine model
- remove the myceliumSeeds
@0oM4R 0oM4R changed the title GridClient:Dynamic_SingleVM: configure myceluim to the network GridClient:Dynamic_SingleVM: enhance the script Feb 2, 2025
@@ -1,6 +1,6 @@
import { FilterOptions, MachinesModel } from "../src";
import { Features, FilterOptions, generateRandomHexSeed, MachinesModel } from "../src";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused import generateRandomHexSeed

@0oM4R 0oM4R requested a review from amiraabouhadid February 2, 2025 12:24
@0oM4R 0oM4R merged commit d3db821 into development Feb 2, 2025
9 checks passed
@0oM4R 0oM4R deleted the development_fix_dynamic_vm_script branch February 2, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants