-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GridClient:Dynamic_SingleVM: enhance the script #3846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaradel
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we exclude node 11 for now so the test can pass on Devnet? |
AhmedHanafy725
requested changes
Feb 2, 2025
…into development_fix_dynamic_vm_script
- use the pinged node in machine model - remove the myceliumSeeds
AhmedHanafy725
approved these changes
Feb 2, 2025
@@ -1,6 +1,6 @@ | |||
import { FilterOptions, MachinesModel } from "../src"; | |||
import { Features, FilterOptions, generateRandomHexSeed, MachinesModel } from "../src"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused import generateRandomHexSeed
amiraabouhadid
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the issue maybe related to the network name; at that run that there is another network with the same name but not configured to support myceluim; this should be solved in #3822
but currently we enhanced the script and the workflow is passed
support features and ping node
Changes
pingNode
to select a reachable nodeRelated Issues
#3834
Tested Scenarios
deployed a dynamic single vm on qa

https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/13051502010/job/36412609964 qa workflow passed
Documentation PR
For UI changes, Please provide the Documentation PR on info_grid
To consider
Preliminary Checks:
UI Checks:
Code Quality Checks:
Testing Checklist
General Checklist