-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DomainName]: Fix status binding #3923
Conversation
… binding. - replace VForm with formValidator - use inputValidator for the inner fileds - improve status binding
…olean casting for status checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.loom.com/share/cb422b61277f4c188999369c4f6a96df?sid=c8906499-cac4-4822-8906-92a7de080eb0
add btn activation seems to behave correctly when toggling wireguard/mycelium and custom domain but it always fails to add domain even though console logs indicate successful transaction :/
Also might need to open issue to clear custom domain text field when custom domain is switched on/off
In custom domain case you have to add a record to your domain to the mentioned ip please check the yellow alert |
created a separate issue for custom domain switch #3939 |
Description
The isssue was after resetting the value while reload; the status got reset to init and never got updated agnain
Changes
bindstate
to be passed on the form status not only modevalue which is valid valueRelated Issues
Tested Scenarios
manage domain dialog
in all of that cases the form got reset back to init state and the add button is disabled
Screen.Recording.2025-02-20.at.1.12.53.PM.mov
applications
those cases the deployemnt will be blocked on the filds and if you select a proper values will work fine
Screen.Recording.2025-02-20.at.1.23.44.PM.mov
domains
same mentioned scenarios
Screen.Recording.2025-02-20.at.1.38.36.PM.mov
Documentation PR
For UI changes, Please provide the Documentation PR on info_grid
To consider
Preliminary Checks:
UI Checks:
Code Quality Checks:
Testing Checklist
General Checklist