Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DomainName]: Fix status binding #3923

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Feb 20, 2025

Description

The isssue was after resetting the value while reload; the status got reset to init and never got updated agnain

Changes

  • form validator: added a prop that define if the field is in init state
  • domain name:
  • use form validator and inputvalidator
  • refactor the bindstate to be passed on the form status not only modevalue which is valid value

Related Issues

Tested Scenarios

manage domain dialog

  1. select domain node then changed the interface
  2. select domain node then enabled the custom domain
  3. select domain node then reload domain nodes
    in all of that cases the form got reset back to init state and the add button is disabled
Screen.Recording.2025-02-20.at.1.12.53.PM.mov

applications

  • in the initail state tab is not reporing as invalid
  1. select domain node then reload
  2. select domain node then toggle the custom domain

those cases the deployemnt will be blocked on the filds and if you select a proper values will work fine

Screen.Recording.2025-02-20.at.1.23.44.PM.mov

domains

same mentioned scenarios

Screen.Recording.2025-02-20.at.1.38.36.PM.mov

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

  • Preliminary Checks
    • Does it completely address the issue linked?
    • What about edge cases?
    • Does it meet the specified acceptance criteria?
    • Are there any unintended side effects?
    • Does the PR adhere to the team's coding conventions, style guides, and best practices?
    • Does it integrate well with existing features?
    • Does it impact the overall performance of the application?
    • Are there any bottlenecks or slowdowns?
    • Has it been optimized for efficiency?
    • Has it been adequately tested with unit, integration, and end-to-end tests?
    • Are there any known defects or issues?
    • Is the code well-documented?
    • Are changes to documentation reflected in the code?

UI Checks:

  • UI Checks
    • If a UI design is provided/ does it follow it?
    • Does every button work?
    • Is the data displayed logical? Is it what you expected?
    • Does every validation work?
    • Does this interface feel intuitive?
    • What about slow network? Offline?
    • What if the gridproxy/graphql/chain is failing?
    • What would a first time user have a hard time navigating here?

Code Quality Checks:

  • Code Quality Checks
    • Code formatted/linted? Are there unused imports? .. etc
    • Is there redundant/repeated code?
    • Are there conditionals that are always true or always false?
    • Can we write this more concisely?
    • Can we reuse this code? If yes, where?
    • Will the changes be easy to maintain and update in the future?
    • Can this code become too complex to understand for other devs?
    • Can this code cause future integration problems?

Testing Checklist

  • Does it Meet the specified acceptance criteria.
  • Test if changes can affect any other functionality.
  • Tested with unit, integration, and end-to-end tests.
  • Tested the un-happy path and rollback scenarios.
  • Documentation updated to meet the latest changes.
  • Check automated tests working successfully with the changes.
  • Can be covered by automated tests.

General Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring
  • Screenshots/Video attached (needed for UI changes)

… binding.

- replace VForm with formValidator
- use inputValidator for the inner fileds
- improve status binding
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.loom.com/share/cb422b61277f4c188999369c4f6a96df?sid=c8906499-cac4-4822-8906-92a7de080eb0
add btn activation seems to behave correctly when toggling wireguard/mycelium and custom domain but it always fails to add domain even though console logs indicate successful transaction :/
Also might need to open issue to clear custom domain text field when custom domain is switched on/off

@0oM4R
Copy link
Contributor Author

0oM4R commented Feb 24, 2025

https://www.loom.com/share/cb422b61277f4c188999369c4f6a96df?sid=c8906499-cac4-4822-8906-92a7de080eb0

add btn activation seems to behave correctly when toggling wireguard/mycelium and custom domain but it always fails to add domain even though console logs indicate successful transaction :/

In custom domain case you have to add a record to your domain to the mentioned ip please check the yellow alert

@0oM4R 0oM4R requested a review from amiraabouhadid February 24, 2025 13:24
@amiraabouhadid
Copy link
Contributor

created a separate issue for custom domain switch #3939

@0oM4R 0oM4R merged commit bed65cb into development Feb 25, 2025
9 of 10 checks passed
@0oM4R 0oM4R deleted the development_fix_domainName_status branch February 25, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants