-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development registrar client #4
base: development
Are you sure you want to change the base?
Conversation
0f24159
to
a546fa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ya Salma 👏
I have some suggestions :
- I think we are going to use the module types in other places in the project rather than the module itself; IMO it's better to have an outer directory for types
- we need some extra info about how to start the project what are the requirements how to build and how to run tests.
That was an overview of the code will test the functionality and comment back with the results.
affd109
to
605877a
Compare
605877a
to
232d833
Compare
Thanks! I've addressed almost all the suggestions and comments. |
Description
implemented client for registrar :
Setup monorepo
used yarn with lerna + prettier + eslint
Related issues
#2 (comment)
#1 (comment)