Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development registrar client #4

Open
wants to merge 15 commits into
base: development
Choose a base branch
from

Conversation

SalmaElsoly
Copy link

Description

implemented client for registrar :

  • farm(create/list/get/update)
  • account(create/get by public key / get by twin id / update)
  • node(register/list/get/update/ report uptime)
  • zos(get version)

Setup monorepo

used yarn with lerna + prettier + eslint

Related issues

#2 (comment)
#1 (comment)

@SalmaElsoly SalmaElsoly force-pushed the development_registrar_client branch from 0f24159 to a546fa6 Compare February 18, 2025 13:34
@SalmaElsoly SalmaElsoly requested a review from xmonader February 18, 2025 13:35
Copy link

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ya Salma 👏

I have some suggestions :

  • I think we are going to use the module types in other places in the project rather than the module itself; IMO it's better to have an outer directory for types
  • we need some extra info about how to start the project what are the requirements how to build and how to run tests.

That was an overview of the code will test the functionality and comment back with the results.

@SalmaElsoly SalmaElsoly force-pushed the development_registrar_client branch from affd109 to 605877a Compare February 27, 2025 09:57
@SalmaElsoly SalmaElsoly force-pushed the development_registrar_client branch from 605877a to 232d833 Compare February 27, 2025 09:57
@SalmaElsoly
Copy link
Author

Great work ya Salma 👏

I have some suggestions :

  • I think we are going to use the module types in other places in the project rather than the module itself; IMO it's better to have an outer directory for types
  • we need some extra info about how to start the project what are the requirements how to build and how to run tests.

That was an overview of the code will test the functionality and comment back with the results.

Thanks! I've addressed almost all the suggestions and comments.

@SalmaElsoly SalmaElsoly requested a review from 0oM4R February 27, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants