Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup public config #43

Merged
merged 1 commit into from
Feb 17, 2025
Merged

setup public config #43

merged 1 commit into from
Feb 17, 2025

Conversation

Omarabdul3ziz
Copy link

@Omarabdul3ziz Omarabdul3ziz commented Jan 28, 2025 •
edited
Loading

@Omarabdul3ziz
setup public config
ebb4bb0 
- setup the persistance file in the netlight module
- add the chain events listner to catch PublicConfigStored events for
  the node
- run the redis consumer to act on the stored event
@Omarabdul3ziz Omarabdul3ziz marked this pull request as draft January 29, 2025 09:44
@Omarabdul3ziz Omarabdul3ziz marked this pull request as ready for review February 17, 2025 13:56
@Omarabdul3ziz Omarabdul3ziz merged commit 237fab5 into split_common_code Feb 17, 2025
1 check failed
@Omarabdul3ziz Omarabdul3ziz deleted the split/setup_public_config branch February 17, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashraffouda ashraffouda ashraffouda approved these changes

@muhamadazmy muhamadazmy Awaiting requested review from muhamadazmy muhamadazmy is a code owner

@rawdaGastan rawdaGastan Awaiting requested review from rawdaGastan rawdaGastan is a code owner

@xmonader xmonader Awaiting requested review from xmonader xmonader is a code owner

@Eslam-Nawara Eslam-Nawara Awaiting requested review from Eslam-Nawara Eslam-Nawara is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Omarabdul3ziz @ashraffouda