This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Add "interactively" parameter to partial sheet presentation delegate #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwroth
requested review from
scottasoutherland,
Abdul-Moiz and
Muhieddine-El-Kaissi
| @@ -76,7 +80,9 @@ open class PartialSheetPresentation: NSObject, UIViewControllerTransitioningDele | |||
| return nil | |||
| } | |||
|
|
|||
| return PercentDrivenInteractiveTransition(panGestureRecognizer: partialSheetPresentationController.panGestureRecognizer) | |||
| return PercentDrivenInteractiveTransition(panGestureRecognizer: partialSheetPresentationController.panGestureRecognizer) { didFinish in | |||
| partialSheetPresentationController.didCompleteInteractiveTransition(success: didFinish) | |||
There was a problem hiding this comment.
i find both didFinish and success to be a bit confusing for names here. Maybe didDismiss ?
There was a problem hiding this comment.
Frankly, the API is a little confusing. The dismiss is what triggers the interactive animation, so technically, it did "dismiss" even if the user doesn't swipe all the way and cancels the interaction. The question is, was the dismissal able to complete or not.
I could refactor this to not trigger the callback in the cancelled case. Maybe that would be clearer.
There was a problem hiding this comment.
I see. That makes sense then.
I'll leave it up to you if you want to change the api.
scottasoutherland
approved these changes
Jul 30, 2024
scottasoutherland
approved these changes
Jul 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an additional boolean argument,
interactively, to the partialSheetPresentationControllerDidDismissSheet() method of PartialSheetPresentationControllerDelegate. This value is set to true when the dismissal of the modal is triggered by user interaction with the modal container (tapping the darkened background area or swiping down on the modal), rather than with the contents of the model itself.