Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #46

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Add more tests #46

merged 1 commit into from
Jan 25, 2025

Conversation

tianon
Copy link
Owner

@tianon tianon commented Jan 25, 2025

Hopefully, this helps us catch more missing functionality (#45).

@tianon
Copy link
Owner Author

tianon commented Jan 25, 2025

I verified this against the current-pushed bash:4 image, and it does fail (and rebuilding from latest succeeds), but I haven't actually tested 3.x at all so this'll be fun! 😄

@tianon
Copy link
Owner Author

tianon commented Jan 25, 2025

Ooh, looks like #45 might have needed to include 4.4 also? 👀

Also, 3.x doesn't support coproc, which is fair!

tianon added a commit that referenced this pull request Jan 25, 2025
Hopefully, this helps us catch more missing functionality.
@tianon
Copy link
Owner Author

tianon commented Jan 25, 2025

Successsssss!

@tianon tianon merged commit 54a7847 into tianon:master Jan 25, 2025
15 checks passed
@tianon tianon deleted the tests branch January 25, 2025 01:15
@tianon
Copy link
Owner Author

tianon commented Jan 25, 2025

There's more to add here, but this is a definite improvement.

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jan 28, 2025
Changes:

- tianon/docker-bash@eea20aa: Update devel to 20250124, commit 25e213a551dc808c7f29360075bad4806fb9fec5
- tianon/docker-bash@54a7847: Merge pull request tianon/docker-bash#46 from self-five/tests
- tianon/docker-bash@8f072da: Add more tests
- tianon/docker-bash@9d45ba2: Also apply job control fix to 4.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant