Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: top level stack pattern #1146

Merged
merged 7 commits into from
Feb 12, 2025
Merged

WIP: top level stack pattern #1146

merged 7 commits into from
Feb 12, 2025

Conversation

sss-create
Copy link
Collaborator

so far, the first pattern in the top-level stack has to be a single value
eg: 1 2, 3 4 results in 1 [2, 3 4]. Where in Strudel it would become [1 2, 3 4]
also: no elongate or repeat working in first to be stacked (single) pattern

maybe @polymorphicengine could give a comment on the overall approach.

would resolve #980.

@sss-create
Copy link
Collaborator Author

I assume that modifying the left-hand side of a , (and, I believe, the same applies to top-level |) would require a more significant intervention into the and parsing mechanisms? Potentially involving the decoupling of them from the bracket, curly brackets, and parentheses parsing?

@yaxu
Copy link
Member

yaxu commented Feb 10, 2025

Would it work to just generalise pPolyIn by removing brackets $ from it, and use that as the entrypoint for the parser, instead of pSequence?

@sss-create
Copy link
Collaborator Author

@yaxu, that could be an idea! I will try this tomorrow, time to go to bed soon 😴

@sss-create sss-create changed the title WIP: to level stack pattern WIP: top level stack pattern Feb 11, 2025
@sss-create sss-create marked this pull request as ready for review February 12, 2025 16:12
@sss-create
Copy link
Collaborator Author

@yaxu, your suggestion did work! Will merge this now. One more thing to do is to support the combined use of | and , as described in #980. I'll look into that. Maybe you already can think of a way to support this, again?

@sss-create sss-create merged commit 85f6f1e into tidalcycles:dev Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mininotation should support top-level , and |
2 participants