fix(ios): prevent icon animation in TabGroup when closing modal windows

[m1ga]

var win1 = Ti.UI.createWindow();
var win2 = Ti.UI.createWindow();
win1.addEventListener("click", function() {
  var win3 = Ti.UI.createWindow();  
  win3.open({modal:true})
})
var tab1 = Ti.UI.createTab({window: win1,icon:"/images/appicon.png",title: 'Blue'});
var tab2 = Ti.UI.createTab({window: win2,icon:"/images/appicon.png",title: 'Red'});
tabGroup = Ti.UI.createTabGroup({tabs: [tab1, tab2]});
tabGroup.open();

Current issue:

iphone_tabgroup.mov

Icons will animate when you close the window. When removing that line it won't update the icons.

Also tested a normal app. Looks fine and shows the correct icons without issues.

Any thoughts if that code is still needed?

[hansemannn]

What's the reason behind the trait collection check? If it's different, the underlaying issue should be in the presented modal state, not the return state.

[m1ga]

@prashantsaini1 Think you'll have to check that as that one was generated from your AI

[prashantsaini1]

The didChangeTraitCollection is triggered only for ≥ 26, not below this version. It seems something must have changed internally in how the iOS handles it now for different classes (so we only compare it for horizontal + vertical sizes and color appearances for system dark/light modes).