Fix LineString feature encoding to use all points and add tests for validation #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and testing of LineString features in the MVT encoding logic. The main change ensures that LineString features are only encoded if they contain at least two points, and that all points are used in the encoding process. New tests have been added to verify this behavior.
LineString encoding improvements
mvtAddFeatureininternal/server/mvt.goto only encode LineString features with two or more points, and fixed a bug where only the first point was used in the loop instead of all points.Testing enhancements
internal/server/mvt_test.goto verify that LineString features are encoded using all points, and that LineStrings with fewer than two points do not produce geometry commands.