Skip to content

Conversation

@krkeshav
Copy link
Contributor

@krkeshav krkeshav commented Dec 29, 2025

Please do not open a pull request without first filing an issue and/or discussing the feature directly with the project maintainer.

Please ensure you adhere to every item in this list

  • This PR was pre-approved by the project maintainer
  • I have self-reviewed the code
  • I have added all necessary tests

Describe your changes

I have added check for NaN and infinity, using math package

Issue number and link

#793

@krkeshav
Copy link
Contributor Author

krkeshav commented Dec 29, 2025

@tidwall This resulted in a downtime as we received few bot requests which had NaN in params and apparently strconv.ParseFloat doesn't return error with NaN and infinities.
Hence, the intersect query was taking few seconds to return and this choked the entire flow.

Let me know if I need to do any other changes. Although UTs are passing in my local, but there are no test files for files where I made changes.

@tidwall
Copy link
Owner

tidwall commented Dec 30, 2025

@krkeshav To maintain compatibility we'll probably need to fix the underlying issue, which is not to allow inserting NaN points into the rtree.

@tidwall tidwall merged commit 3010191 into tidwall:master Jan 6, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants