Skip to content

Quant methods #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Quant methods #291

wants to merge 14 commits into from

Conversation

dajmcdon
Copy link

This is the first of a few possible PRs that our team discussed with @topepo and @EmilHvitfeldt .

Features and bug fixes:

  • Allows some standard vec arithmetic on the quantile_pred object.
  • Adds vec_ptype2 and vec_cast methods for quantile_pred. Without these, occasional downstream bugs happened on the object.
  • Adds functionality to "impute" quantiles by interpolating the quantile function. This is most useful for "extracting" some specific quantile from the quantile_pred object, say the median. This way, rather than trying to "match" doubles, it can just compute it directly. It can also be used to expand the set of quantiles represented by the object.
  • Some helper functions for the above: snap() and is_quantile_pred().

@topepo
Copy link
Member

topepo commented Jul 29, 2025

Hey @dajmcdon. We'll take a look at this in about 2 weeks. Still in the "open heart surgery" changes to tune and company, trying to make a conference deadline.

@EmilHvitfeldt
Copy link
Member

What Max said, i have 2 small things to work on in the meantime:

@dajmcdon
Copy link
Author

dajmcdon commented Aug 6, 2025

Thanks both! And no hurry. We'll probably want to handle #282 simultaneously. (FYI @brookslogan is a member of our team).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants