-
Notifications
You must be signed in to change notification settings - Fork 20
Quant methods #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dajmcdon
wants to merge
14
commits into
tidymodels:main
Choose a base branch
from
dajmcdon:quant-methods
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Quant methods #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @dajmcdon. We'll take a look at this in about 2 weeks. Still in the "open heart surgery" changes to tune and company, trying to make a conference deadline. |
What Max said, i have 2 small things to work on in the meantime:
|
Thanks both! And no hurry. We'll probably want to handle #282 simultaneously. (FYI @brookslogan is a member of our team). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a few possible PRs that our team discussed with @topepo and @EmilHvitfeldt .
Features and bug fixes:
quantile_pred
object.vec_ptype2
andvec_cast
methods forquantile_pred
. Without these, occasional downstream bugs happened on the object.quantile_pred
object, say the median. This way, rather than trying to "match" doubles, it can just compute it directly. It can also be used to expand the set of quantiles represented by the object.snap()
andis_quantile_pred()
.