Add R4.6 snapshot variants for BPE tests - #310
Merged
Merged
Conversation
CI runners were bumped to R 4.6.0, so the variant-aware snapshot tests in test-tokenize_bpe.R and test-tokenizer-tokenizersbpe.R (which key snapshots on r_version()) had no R4.6 variant and reported 'Adding new snapshot for variant R4.6', failing R CMD check on Windows. The error messages are produced by textrecipes itself and are identical across R 4.3-4.5, so copy the existing R4.5 snapshots into a new R4.6 variant directory.
The Windows oldrel-4 runner uses R 4.2.3, so r_version() returns 'R4.2', which likewise had no variant snapshot directory. Copy the identical R4.3 snapshots into an R4.2 variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GHA checks on #309 (and any current PR) fail on Windows R CMD check with two test failures, unrelated to that PR's
step_word_embeddings()work:Cause
Both tests use
expect_snapshot(variant = r_version()), wherer_version()ispaste0("R", getRversion()[, 1:2]). The CI runners were bumped to R 4.6.0, sor_version()now returns"R4.6". There were variant snapshot directories forR4.3,R4.4, andR4.5but none forR4.6, so testthat treats it as a brand-new snapshot, which is a failure under CI.Fix
The expected error messages here are generated by textrecipes itself and are byte-identical across R 4.3-4.5, so this adds an
R4.6variant directory copied from the existingR4.5snapshots.(The macOS R-CMD-check failure on #309 is separate:
recipesfailed todyn.loadon the R 4.6.0 arm64 runner, a transient upstream binary issue not addressed here.)