Make position_dodge2() work for geom_violin()#6664
Merged
teunbrand merged 11 commits intotidyverse:mainfrom Dec 4, 2025
Merged
Make position_dodge2() work for geom_violin()#6664teunbrand merged 11 commits intotidyverse:mainfrom
position_dodge2() work for geom_violin()#6664teunbrand merged 11 commits intotidyverse:mainfrom
Conversation
thomasp85
approved these changes
Dec 3, 2025
Member
thomasp85
left a comment
There was a problem hiding this comment.
Just because dodging is so finicky it would be nice with some unit tests to cover this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6663.
It has the fix to treat multi-row groups correctly, by dodging only the first row of each group and then reinserting the results over multiple rows.
Notably, it does not have fancy detection of when this should apply.
It is currently controlled by
position_dodge2(group_row)but ideally, this would be detected automatically.Created on 2025-09-30 with reprex v2.1.1