Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cppcheck ci #211

Merged
merged 25 commits into from
Jun 27, 2024
Merged

feat: add cppcheck ci #211

merged 25 commits into from
Jun 27, 2024

Conversation

xygyo77
Copy link
Contributor

@xygyo77 xygyo77 commented Jun 20, 2024

Description

Add cppcheck to ci. At the same time, the correction of the indicated items in cppcheck is carried out and the cppcheck is set to its initial state.

Related links

https://tier4.atlassian.net/browse/RT2-1667

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xygyo77 xygyo77 requested a review from ymski June 20, 2024 06:47
@xygyo77 xygyo77 changed the title Add cppcheck ci feat: add cppcheck ci Jun 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.65%. Comparing base (0d5fe6f) to head (400dbc4).
Report is 14 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #211      +/-   ##
========================================
+ Coverage   6.70%   7.65%   +0.94%     
========================================
  Files         15      15              
  Lines        969     888      -81     
  Branches     374     375       +1     
========================================
+ Hits          65      68       +3     
+ Misses       873     809      -64     
+ Partials      31      11      -20     
Flag Coverage Δ
differential 7.65% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xygyo77 xygyo77 merged commit 673afd1 into tier4:main Jun 27, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants