Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jazzy support #222

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

miyakoshi-dev
Copy link
Contributor

@miyakoshi-dev miyakoshi-dev commented Dec 12, 2024

Description

jazzy support

Related links

https://tier4.atlassian.net/browse/RT2-1803

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.08%. Comparing base (0d5fe6f) to head (133b06d).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #222      +/-   ##
========================================
+ Coverage   6.70%   9.08%   +2.37%     
========================================
  Files         15      15              
  Lines        969     969              
  Branches     374     376       +2     
========================================
+ Hits          65      88      +23     
+ Misses       873     789      -84     
- Partials      31      92      +61     
Flag Coverage Δ
differential 9.08% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miyakoshi-dev miyakoshi-dev requested a review from ymski December 12, 2024 03:06
Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link problems with yaml-cpp in the jazzy environment were reported here.
We have confirmed that after the change it is possible to build in jazzy and humble.
LGTM.

@miyakoshi-dev miyakoshi-dev merged commit 0886a10 into tier4:main Jan 29, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants