Testing #148
Merged
Testing #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobRossmiller-TG
requested review from
wyattjoynertg,
billshitg,
parkererickson-tg and
GabrielTigerGraph
tests/test/test_centrality.py
Outdated
| "file_path": "", | ||
| } | ||
| url = os.path.join( | ||
| self.base_url, "degree_centrality/in_degree/", test_name + ".json" |
There was a problem hiding this comment.
Why are the baselines external to the test? How do people add new baselines?
tests/test/util.py
Outdated
| username=user_name, | ||
| password=password, | ||
| graphname=graph_name, | ||
| tgCloud=True, |
There was a problem hiding this comment.
tgCloud is a deprecated parameter, and is unnecessary.
tests/test/util.py
Outdated
| graphname=graph_name, | ||
| tgCloud=True, | ||
| ) | ||
| conn.getToken() |
There was a problem hiding this comment.
Potentially parameterize if a user needs to get a token or not? Would be handy for us if we run the test suite against a Zulip machine (which has no token auth enabled by default)
parkererickson-tg
approved these changes
May 10, 2024
billshitg
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize public testing