Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fix desktop services not starting after wlr-randr v0.5.0 #1022

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

kajusnau
Copy link
Contributor

@kajusnau kajusnau commented Feb 18, 2025

Description of changes

  1. Fixed Launcher and Taskbar Services Not Starting After wlr-randr v0.5.0:
    • wlr-randr v0.5.0 rejects standalone CLI arguments, preventing ghaf-launcher and ewwbar services from starting.
    • Forced taskbar and launcher services to use Bash as an interpreter in Exec commands to ensure proper execution when redirecting output.
    • General note for devs: Systemd units do not use shell as an interpreter for Exec commands.
      It's therefore recommended to always call a script with no arguments nor options, or use bash -c (as shown in this PR) to interpret commands properly.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
      • Verify fix works as expected, taskbar and ghaf launcher work at boot.
      • Verify previously introduced fix for log flooding in headless mode still works and is effective.
  • If it is an improvement how does it impact existing functionality?

…dr v0.5.0

- wlr-randr 0.5.0 rejects standalone CLI arguments
- force taskbar and launcher services to use bash as an interpreter in `Exec` commands

Signed-off-by: Kajus Naujokaitis <[email protected]>
@kajusnau kajusnau temporarily deployed to internal-build-workflow February 18, 2025 12:03 — with GitHub Actions Inactive
@kajusnau kajusnau changed the title Desktop: Fix launcher and taskbar services not starting after wlr-ran… Desktop: Fix desktop services not starting after wlr-randr v0.5.0 Feb 18, 2025
@kajusnau kajusnau self-assigned this Feb 18, 2025
@kajusnau kajusnau added the Needs Testing CI Team to pre-verify label Feb 18, 2025
@milva-unikie
Copy link

Tested on Lenovo-X1 (nixos-rebuild switch):

  • Taskbar and app menu are back.
  • Test automation passes.

Also checked the pre-merge pipeline results to confirm that Orin-NX log size remains reduced.

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Feb 18, 2025
@brianmcgillion brianmcgillion merged commit ac25ff1 into tiiuae:main Feb 18, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants