Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add txn write conflict metrics #1551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add txn write conflict metrics #1551

wants to merge 1 commit into from
+3 −0

Conversation

ImSjt
Copy link

@ImSjt ImSjt commented Jan 7, 2025

Issue Number: close #1550
Add transaction write conflict metrics.

@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Jan 7, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

Welcome @ImSjt!

It looks like this is your first PR to tikv/client-go 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to tikv/client-go. 😃

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 7, 2025
@ImSjt
Copy link
Author

ImSjt commented Jan 7, 2025

/approve zyguan

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ImSjt
Once this PR has been reviewed and has the lgtm label, please assign zyguan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ekexium
ekexium reviewed Feb 8, 2025
View reviewed changes
Copy link
Contributor

@ekexium ekexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please resolve the conflicts

@ImSjt ImSjt force-pushed the add_txn_write_conflict_metrics branch from 9dc066e to c87174e Compare February 10, 2025 14:27
@ImSjt
Copy link
Author

ImSjt commented Feb 10, 2025

@ekexium PTAL again.

ekexium
ekexium reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@ekexium ekexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think the metric is not related to lock_resolver. It's more like "WriteConflicts errrors generated from the client side".
Maybe we can remove LockResolverCountWithWriteConflict and make this one a new metric. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekexium ekexium ekexium left review comments

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add transaction write conflict metrics
2 participants
@ImSjt @ekexium