Skip to content

Fix the problem that ttl manager may be unset unexpectedly when LockKeys is called multiple times in a single fair locking stage (#1903)#1909

Open
ti-chi-bot wants to merge 1 commit intotikv:tidb-8.5from
ti-chi-bot:cherry-pick-1903-to-tidb-8.5
Open

Fix the problem that ttl manager may be unset unexpectedly when LockKeys is called multiple times in a single fair locking stage (#1903)#1909
ti-chi-bot wants to merge 1 commit intotikv:tidb-8.5from
ti-chi-bot:cherry-pick-1903-to-tidb-8.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1903

Ref: pingcap/tidb#66571

Summary by CodeRabbit

  • Tests
    • Added comprehensive test coverage for aggressive locking behavior across multiple lock operations, including retry scenarios and TTL management verification.
    • Enhanced test utilities to inspect aggressive locking state and context during transaction operations.

…eys is called multiple times in a single fair locking stage

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2b2d0bf9-8d09-4b0a-b8c7-dd6d34d8605a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 13, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 13, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-03-13 08:01:06.964743734 +0000 UTC m=+596298.476801395: ☑️ agreed by ekexium.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 13, 2026
@ekexium ekexium requested a review from cfzjywxk March 13, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-tidb-8.5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants