Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated method to avoid warning #655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hxingpax
Copy link

fix warning of cargo test:

warning: use of deprecated method `cmake::Config::uses_cxx11`: no longer does anything, C++ is determined based on `cc::Build`, and the macOS issue has been fixed upstream
   --> grpc-sys/build.rs:255:16
    |
255 |         config.uses_cxx11().build()
    |                ^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

Copy link

ti-chi-bot bot commented Feb 11, 2025

Welcome @hxingpax! It looks like this is your first PR to tikv/grpc-rs 🎉

@BusyJay
Copy link
Member

BusyJay commented Feb 11, 2025

Hi, failed CI is not related to your changes, but can you also fix them in this PR?

@taddes
Copy link

taddes commented Feb 11, 2025

I'll chime in since @BusyJay and I discus this issue in #654 and related context to cc-rs and cmake. I'd suggest removing this from the documentation comment and example in cross_compile.md under All diff in fn build_grpc

@BusyJay
Copy link
Member

BusyJay commented Feb 21, 2025

Friendly ping.

Hi, @hxingpax do you still have time to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants