Skip to content

Install bubblewrap for Codex sessions#128

Merged
murrayju merged 1 commit intomainfrom
ox/add-bwrap-setup
Mar 27, 2026
Merged

Install bubblewrap for Codex sessions#128
murrayju merged 1 commit intomainfrom
ox/add-bwrap-setup

Conversation

@murrayju
Copy link
Copy Markdown
Member

Summary

  • install system bubblewrap in the sandbox base image
  • document that Codex sessions now use /usr/bin/bwrap in ox sandboxes

Testing

  • ./bun run check

Copilot AI review requested due to automatic review settings March 27, 2026 23:11
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ox Agent seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@murrayju murrayju merged commit a35ff46 into main Mar 27, 2026
5 of 6 checks passed
@murrayju murrayju deleted the ox/add-bwrap-setup branch March 27, 2026 23:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Installs bubblewrap in the sandbox base Docker image and updates documentation to note that Codex can use /usr/bin/bwrap to avoid the vendored fallback warning.

Changes:

  • Add bubblewrap to sandbox/base.Dockerfile apt packages.
  • Document Codex’s use of system bwrap to suppress the vendored-bubblewrap warning.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
sandbox/base.Dockerfile Installs bubblewrap in the Docker sandbox base image.
docs/agents.md Documents that Codex can use /usr/bin/bwrap in ox sandboxes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

### Codex

Codex uses OpenAI authentication (API key or ChatGPT OAuth). When prompted, ox guides you through the setup.
ox's sandbox image installs system `bubblewrap`, so Codex can use `/usr/bin/bwrap`
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence starts a new paragraph/sentence after the previous period, but begins with lowercase "ox's". Capitalize it (e.g., "Ox's") or format the CLI name consistently (e.g., "ox's").

Suggested change
ox's sandbox image installs system `bubblewrap`, so Codex can use `/usr/bin/bwrap`
`ox`'s sandbox image installs system `bubblewrap`, so Codex can use `/usr/bin/bwrap`

Copilot uses AI. Check for mistakes.
Comment on lines +67 to +68
ox's sandbox image installs system `bubblewrap`, so Codex can use `/usr/bin/bwrap`
without printing its vendored-bubblewrap fallback warning at session startup.
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note reads like it applies to all ox sandboxes, but only the Docker base image is updated in this PR. Cloud sandboxes are built via sandbox/cloud-base-steps.yaml (which currently doesn't install bubblewrap), so Codex sessions on the cloud provider may still lack /usr/bin/bwrap and show the warning. Please either scope the docs to the Docker provider/base image or ensure the cloud base snapshot also installs bubblewrap.

Suggested change
ox's sandbox image installs system `bubblewrap`, so Codex can use `/usr/bin/bwrap`
without printing its vendored-bubblewrap fallback warning at session startup.
In Docker-based sandboxes, ox's base image installs system `bubblewrap`, so Codex can use `/usr/bin/bwrap`
without printing its vendored-bubblewrap fallback warning at session startup. Other sandbox providers may not have `/usr/bin/bwrap` available and can still show this warning.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants