Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reversible create_continuous_aggregate #86

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

intermittentnrg
Copy link
Contributor

No description provided.

@rapito
Copy link

rapito commented Jan 10, 2025

Hi @intermittentnrg, is there anything you need to move this from Draft to Ready for Review?
I would like to have this merged as well.

@intermittentnrg
Copy link
Contributor Author

Awesome. It's good as is, but should be expanded to cover all methods in migration_helpers.

@jonatas
Copy link
Collaborator

jonatas commented Jan 28, 2025

@rapito would you like to push it forward? as you can also be a beta-tester 🤓

@rapito
Copy link

rapito commented Jan 28, 2025

@rapito would you like to push it forward? as you can also be a beta-tester 🤓

Sounds good, I can find some time to finish this up.

@intermittentnrg
Copy link
Contributor Author

the methods we need to support are:

  • create_table if options.key?(:hypertable)
  • create_continuous_aggregate
  • create_continuous_aggregates (alias_method)
  • drop_continuous_aggregate
  • drop_continuous_aggregates (alias_method)
  • create_continuous_aggregate_policy
  • remove_continuous_aggregate_policy (alias_method)
  • create_retention_policy
  • add_retention_policy (alias_method)
  • remove_retention_policy
  • add_compression_policy

drop_* can just be irreversible, tho rails does support extra options that are used only when reversing

So short list without drop_* methods and removing duplicates from aliases.

  • create_continuous_aggregate
  • create_continuous_aggregate_policy
  • create_retention_policy
  • add_compression_policy

@intermittentnrg intermittentnrg force-pushed the reversible-cagg-migrations branch from 1441131 to e5b487e Compare February 10, 2025 21:03
@intermittentnrg intermittentnrg force-pushed the reversible-cagg-migrations branch from e5b487e to 5c5c0b5 Compare February 10, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants